piston-cli: 1.4.3 -> 1.5.0, tweak, fetchFromGitHub, versionCheckHook #370904
+37
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasew
force-pushed
the
20250104-upd-piston
branch
from
1556b5b to
97b7c77
Compare
13 tasks
|
Builds but does not run. After running the binary, it should prompt your for a language, then code to run. EDIT: at least that was the case on 1.4.3. Let me try installing it the non-nix way and see what happens. |
|
|
Works as expected. Thanks for helping me through all this. |
GaetanLepage
requested changes
Jan 4, 2025
Signed-off-by: lucasew <[email protected]>
lucasew
force-pushed
the
20250104-upd-piston
branch
from
97b7c77 to
cde58d0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
piston-cli: 1.4.3 -> 1.5.0, tweak, fetchFromGitHub, versionCheckHook
Replaces: #370707
Tested and it works even though the upstream repo is archived.
nativeInstallCheckInputs is being a no-op for some reason so I put versionCheckHook in nativeCheckInputs.
Signed-off-by: lucasew [email protected]
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.