Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traderepublic-portfolio-downloader: init at 0.18.0 #379381

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

SeineEloquenz
Copy link
Member

traderepublic-portfolio-downloader allows downloading account statements and statistics from the broker Trade Republic.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 4, 2025
@SeineEloquenz SeineEloquenz force-pushed the traderepublic-portfolio-downloader branch from 5257007 to 8b19b89 Compare February 4, 2025 18:00
@SeineEloquenz SeineEloquenz force-pushed the traderepublic-portfolio-downloader branch 2 times, most recently from b700169 to 1381133 Compare February 5, 2025 19:07
@SeineEloquenz SeineEloquenz changed the title traderepublic-portfolio-downloader: init at 0.15.0 traderepublic-portfolio-downloader: init at 0.16.0 Feb 5, 2025
@SeineEloquenz SeineEloquenz force-pushed the traderepublic-portfolio-downloader branch from 1381133 to ed35158 Compare February 6, 2025 16:11
@Shawn8901
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 379381


x86_64-linux

✅ 1 package built:
  • traderepublic-portfolio-downloader

Copy link
Contributor

@Shawn8901 Shawn8901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loaded my docs, looked fine so far.

Copy link
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick + change with lib; otherwise LGTM!

@SeineEloquenz SeineEloquenz force-pushed the traderepublic-portfolio-downloader branch from ed35158 to 3b84d0c Compare February 9, 2025 10:04
@Shawn8901 Shawn8901 added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Feb 9, 2025
@SeineEloquenz SeineEloquenz force-pushed the traderepublic-portfolio-downloader branch from 3b84d0c to 4626b38 Compare February 22, 2025 17:51
@SeineEloquenz SeineEloquenz changed the title traderepublic-portfolio-downloader: init at 0.16.0 traderepublic-portfolio-downloader: init at 0.17.0 Feb 22, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5233

@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Feb 24, 2025
@SeineEloquenz SeineEloquenz changed the title traderepublic-portfolio-downloader: init at 0.17.0 traderepublic-portfolio-downloader: init at 0.18.0 Feb 25, 2025
@SeineEloquenz SeineEloquenz force-pushed the traderepublic-portfolio-downloader branch from 4626b38 to ca739b5 Compare February 25, 2025 11:02
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Feb 25, 2025
@h7x4 h7x4 merged commit 21d55dd into NixOS:master Feb 26, 2025
35 of 36 checks passed
@SeineEloquenz SeineEloquenz deleted the traderepublic-portfolio-downloader branch February 27, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants