uv-sort: init at 0.5.0 #388382
Open
uv-sort: init at 0.5.0 #388382
+42
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengsparks
suggested changes
Mar 9, 2025
|
@GaetanLepage this is the first package that makes use of I tried to build this package using GitHub as a source, but it seems that Here is the tracebackpypa build flags: --no-isolation --outdir dist/ --wheel
* Getting build dependencies for wheel...
* Building wheel...
Traceback (most recent call last):
File "/nix/store/gxp46ny33gykgxsbkyas7b4d64rd27sy-python3.12-pyproject-hooks-1.2.0/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
main()
File "/nix/store/gxp46ny33gykgxsbkyas7b4d64rd27sy-python3.12-pyproject-hooks-1.2.0/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in main
json_out["return_val"] = hook(**hook_input["kwargs"])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/nix/store/gxp46ny33gykgxsbkyas7b4d64rd27sy-python3.12-pyproject-hooks-1.2.0/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 280, in build_wheel
return _build_backend().build_wheel(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/nix/store/pcl9w887942hvk75rwgrbz5vnyqvvwqp-python3.12-hatchling-1.27.0/lib/python3.12/site-packages/hatchling/build.py", line 58, in build_wheel
return os.path.basename(next(builder.build(directory=wheel_directory, versions=['standard'])))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/nix/store/pcl9w887942hvk75rwgrbz5vnyqvvwqp-python3.12-hatchling-1.27.0/lib/python3.12/site-packages/hatchling/builders/plugin/interface.py", line 90, in build
self.metadata.validate_fields()
File "/nix/store/pcl9w887942hvk75rwgrbz5vnyqvvwqp-python3.12-hatchling-1.27.0/lib/python3.12/site-packages/hatchling/metadata/core.py", line 265, in validate_fields
_ = self.version
^^^^^^^^^^^^
File "/nix/store/pcl9w887942hvk75rwgrbz5vnyqvvwqp-python3.12-hatchling-1.27.0/lib/python3.12/site-packages/hatchling/metadata/core.py", line 149, in version
self._version = self._get_version()
^^^^^^^^^^^^^^^^^^^
File "/nix/store/pcl9w887942hvk75rwgrbz5vnyqvvwqp-python3.12-hatchling-1.27.0/lib/python3.12/site-packages/hatchling/metadata/core.py", line 248, in _get_version
version = self.hatch.version.cached
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/nix/store/pcl9w887942hvk75rwgrbz5vnyqvvwqp-python3.12-hatchling-1.27.0/lib/python3.12/site-packages/hatchling/metadata/core.py", line 1456, in cached
raise type(e)(message) from None
RuntimeError: Error getting the version from source `uv-dynamic-versioning`: Unable to detect version control system. Checked: Git. Not installed: Mercurial, Darcs, Subversion, Bazaar, Fossil, Pijul.
ERROR Backend subprocess exited when trying to invoke build_wheel
error: builder for '/nix/store/wzhchk8rk8fkgb22h7wvyykbdw80dacn-uv-sort-0.5.0.drv' failed with exit code 1;
last 25 log lines:
> File "/nix/store/gxp46ny33gykgxsbkyas7b4d64rd27sy-python3.12-pyproject-hooks-1.2.0/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in main
> json_out["return_val"] = hook(**hook_input["kwargs"])
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/nix/store/gxp46ny33gykgxsbkyas7b4d64rd27sy-python3.12-pyproject-hooks-1.2.0/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 280, in build_wheel
> return _build_backend().build_wheel(
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/nix/store/pcl9w887942hvk75rwgrbz5vnyqvvwqp-python3.12-hatchling-1.27.0/lib/python3.12/site-packages/hatchling/build.py", line 58, in build_wheel
> return os.path.basename(next(builder.build(directory=wheel_directory, versions=['standard'])))
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/nix/store/pcl9w887942hvk75rwgrbz5vnyqvvwqp-python3.12-hatchling-1.27.0/lib/python3.12/site-packages/hatchling/builders/plugin/interface.py", line 90, in build
> self.metadata.validate_fields()
> File "/nix/store/pcl9w887942hvk75rwgrbz5vnyqvvwqp-python3.12-hatchling-1.27.0/lib/python3.12/site-packages/hatchling/metadata/core.py", line 265, in validate_fields
> _ = self.version
> ^^^^^^^^^^^^
> File "/nix/store/pcl9w887942hvk75rwgrbz5vnyqvvwqp-python3.12-hatchling-1.27.0/lib/python3.12/site-packages/hatchling/metadata/core.py", line 149, in version
> self._version = self._get_version()
> ^^^^^^^^^^^^^^^^^^^
> File "/nix/store/pcl9w887942hvk75rwgrbz5vnyqvvwqp-python3.12-hatchling-1.27.0/lib/python3.12/site-packages/hatchling/metadata/core.py", line 248, in _get_version
> version = self.hatch.version.cached
> ^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/nix/store/pcl9w887942hvk75rwgrbz5vnyqvvwqp-python3.12-hatchling-1.27.0/lib/python3.12/site-packages/hatchling/metadata/core.py", line 1456, in cached
> raise type(e)(message) from None
> RuntimeError: Error getting the version from source `uv-dynamic-versioning`: Unable to detect version control system. Checked: Git. Not installed: Mercurial, Darcs, Subversion, Bazaar, Fossil, Pijul.
>
> ERROR Backend subprocess exited when trying to invoke build_wheel
For full logs, run 'nix log /nix/store/wzhchk8rk8fkgb22h7wvyykbdw80dacn-uv-sort-0.5.0.drv'. |
ethancedwards8
suggested changes
Mar 9, 2025
Comment on lines
+11
to
+16
|
|
||
| src = fetchPypi { | ||
| pname = "uv_sort"; | ||
| inherit version; | ||
| hash = "sha256-qCShDuKBFS4omcsntZ1wzRtAKTbp8CfTw0IIAgxBvcE="; | ||
| }; |
There was a problem hiding this comment.
fetchFromGitHub is preferred unless there is a compelling reason to not use it. If so, put in a comment
There was a problem hiding this comment.
My comment here shows that a build from GitHub does not work. I suppose @aaronjheng should document the error in a comment, unless Gaetan happens to fix it first.
Comment on lines
+29
to
+31
| nativeCheckInputs = with python3Packages; [ | ||
| pytestCheckHook | ||
| ]; |
There was a problem hiding this comment.
nit and not blocking, but for just one input here you probably don't need to use with and it'll increase eval times to remove it
GaetanLepage
reviewed
Mar 9, 2025
| typer | ||
| ]; | ||
|
|
||
| build-system = with python3Packages; [ |
There was a problem hiding this comment.
Please, put build-system before dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.