-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark broken kernel modules on Linux 4.18 #45410
Conversation
@@ -51,5 +51,6 @@ stdenv.mkDerivation rec { | |||
platforms = platforms.linux; | |||
license = licenses.gpl2Plus; | |||
maintainers = with maintainers; [ jcumming wizeman wkennington fpletz globin ]; | |||
broken = stdenv.lib.versionAtLeast kernel.version "4.18"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module will be removed eventually when zfs issues a new release, so we do have to put any effort into this one.
@@ -33,5 +33,6 @@ stdenv.mkDerivation rec { | |||
license = lib.licenses.gpl2; | |||
maintainers = with lib.maintainers; [ makefu ]; | |||
platforms = lib.platforms.linux; | |||
broken = stdenv.lib.versionAtLeast kernel.version "4.18"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @makefu
@@ -41,5 +41,6 @@ in stdenv.mkDerivation { | |||
platforms = [ "i686-linux" "x86_64-linux" ]; | |||
license = licenses.gpl2; | |||
maintainers = with maintainers; [ markuskowa ]; | |||
broken = stdenv.lib.versionAtLeast kernel.version "4.18"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @markuskowa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up. I'll keep an eye on the issue.
@@ -59,5 +59,6 @@ in stdenv.mkDerivation { | |||
license = licenses.gpl2; | |||
maintainers = with maintainers; [ ck3d ]; | |||
priority = -1; | |||
broken = stdenv.lib.versionAtLeast kernel.version "4.18"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ck3d
@@ -51,7 +51,8 @@ in stdenv.mkDerivation rec { | |||
license = licenses.ipl10; | |||
platforms = platforms.linux; | |||
maintainers = [ maintainers.z77z maintainers.spacefrogg ]; | |||
broken = versionOlder kernel.version "3.18"; | |||
broken = versionOlder kernel.version "3.18" || | |||
versionAtLeast kernel.version "4.18"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @spacefrogg
Marking those as broken, should be fine. I just wanted to make sure maintainers are notified. |
@Mic92 thanks for the heads-up, there is an open PR for exfat-nofuse in upstream dorimanx/exfat-nofuse#137 , i will track it and once merged i will update the package |
Also latest nvidia module is broken on 4.18 :) |
@Yardanico can you also open a pull request for that? |
aha, I didn't test any unfree software |
Motivation
Not having these marked as broken makes it difficult to
nox-review
kernel changes, since it's not clear whether modules have been broken by the change or were always broken.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)