Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

z-lua: fix build on darwin #69635

Merged
merged 1 commit into from
Sep 27, 2019
Merged

z-lua: fix build on darwin #69635

merged 1 commit into from
Sep 27, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 27, 2019

Motivation for this change

wrap LUA_CPATH manually instead of lua.withPackages. We can't use lua.withPackages, because on darwin shebangs can't point to interpreted (shebang'd) scripts. See #23018
supersedes and closes #68920

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
z-lua: wrap LUA_CPATH manually instead of lua.withPackages
0f1ce17 
We can't use lua.withPackages, because on darwin shebangs can't point to
interpreted (shebang'd) scripts. See #23018
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 27, 2019
@marsam marsam merged commit 9c1eb7a into NixOS:master Sep 27, 2019
@marsam marsam deleted the fix-z-lua-darwin branch September 27, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marsam