runInLinuxVM: Ensure tools requiring /etc/passwd work #80680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes, but is not limited to:
See
Motivation for this change
Fix a system regression in 19.09, where nixops will not work using libvirtd, as pointed out personally to me by @JoeDupuis.
This fix, though, is a much broader fix, and could fix any tool that tries to identify the user in this step.
Things done
Tested using this:
You can verify that without this fix, both on unstable, and 19.09 this fails in three different, but coherent ways. With this fix applied, it works.
This should be backported to 19.09, in my opinion, as this is a system breakage from a minor bump from nix in the nixops ecosystem.
This has to be backported to 20.03 if accepted in master.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)