Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arcanist: Fix on darwin #87406

Merged
merged 1 commit into from
May 14, 2020
Merged

arcanist: Fix on darwin #87406

merged 1 commit into from
May 14, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented May 9, 2020 •
edited
Loading

Motivation for this change

With recent work done on the PHP packaging, the PHP executable is by default a wrapper script. Darwin doesn't like scripts in the shebang of another script, so we have to wrap arcanist, feeding the script as an argument to PHP instead. See #86881 and #23018.

I haven't thoroughly tested this, since I don't use arcanist. Can someone who does make sure it actually works? :) The executable runs, but I don't know if all commands work as expected...

cc @purcell

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz
arcanist: Fix on darwin
2f61275 
With recent work done on the PHP packaging, the PHP executable is by
default a wrapper script. Darwin doesn't like scripts in the shebang
of another script, so we have to wrap arcanist, feeding the script as
an argument to PHP instead. See NixOS#86881 and NixOS#23018.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 9, 2020
@talyz talyz requested a review from aanderse May 9, 2020 16:58
@ofborg ofborg bot requested a review from thoughtpolice May 9, 2020 17:05
@talyz talyz mentioned this pull request May 10, 2020
Closed
@veprbl veprbl linked an issue May 11, 2020 that may be closed by this pull request
arcanist: not executable on Darwin due to wrappers in shebang #86881
Closed
@purcell
Copy link
Member

purcell commented May 13, 2020

I built the modified derivation locally and it seems to work fine for me on Darwin.

@talyz talyz merged commit 11399d1 into NixOS:master May 14, 2020
@tristanpemble tristanpemble mentioned this pull request Aug 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arcanist: not executable on Darwin due to wrappers in shebang
2 participants
@talyz @purcell