-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qemu: add override qemu_full #94370
qemu: add override qemu_full #94370
Conversation
Please remove the master merge commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't set it to true unconditionally. I left a comment in the code review.
Also please add the motivation you detailed in your PR description to the commit changing the knob. It will make it much easier for someone (likely neither me nor you) to figure out the why when debugging/refactoring something.
qemu_full enables samba and ceph support because otherwise enabling them triggers recompilation of qemu package that takes a long time. Similar options can be enabled later on. qemu_full is based on complete qemu package, so hostCpuOnly is not enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still not super happy about the amounts of QEMU packages that we have in nixpkgs but that isn't your fault nor something that I can ask you to change.
Motivation for this change
#41615
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)