Fix missing required parameters

Nixtla · May 9, 2024 · 17a895b · 17a895b
1 parent 5a013dd
commit 17a895b
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 0 deletions.
diff --git a/nbs/common.base_multivariate.ipynb b/nbs/common.base_multivariate.ipynb
@@ -107,13 +107,17 @@
     "                 alias=None,\n",
     "                 optimizer=None,\n",
     "                 optimizer_kwargs=None,\n",
+    "                 lr_scheduler=None,\n",
+    "                 lr_scheduler_kwargs=None,\n",
     "                 **trainer_kwargs):\n",
     "        super().__init__(\n",
     "            random_seed=random_seed,\n",
     "            loss=loss,\n",
     "            valid_loss=valid_loss,\n",
     "            optimizer=optimizer,\n",
     "            optimizer_kwargs=optimizer_kwargs,\n",
+    "            lr_scheduler=lr_scheduler,\n",
+    "            lr_scheduler_kwargs=lr_scheduler_kwargs,            \n",
     "            futr_exog_list=futr_exog_list,\n",
     "            hist_exog_list=hist_exog_list,\n",
     "            stat_exog_list=stat_exog_list,\n",

diff --git a/nbs/common.base_recurrent.ipynb b/nbs/common.base_recurrent.ipynb
@@ -112,13 +112,17 @@
     "                 alias=None,\n",
     "                 optimizer=None,\n",
     "                 optimizer_kwargs=None,\n",
+    "                 lr_scheduler=None,\n",
+    "                 lr_scheduler_kwargs=None,\n",
     "                 **trainer_kwargs):\n",
     "        super().__init__(\n",
     "            random_seed=random_seed,\n",
     "            loss=loss,\n",
     "            valid_loss=valid_loss,\n",
     "            optimizer=optimizer,\n",
     "            optimizer_kwargs=optimizer_kwargs,\n",
+    "            lr_scheduler=lr_scheduler,\n",
+    "            lr_scheduler_kwargs=lr_scheduler_kwargs,\n",
     "            futr_exog_list=futr_exog_list,\n",
     "            hist_exog_list=hist_exog_list,\n",
     "            stat_exog_list=stat_exog_list,\n",

diff --git a/nbs/common.base_windows.ipynb b/nbs/common.base_windows.ipynb
@@ -117,13 +117,17 @@
     "                 alias=None,\n",
     "                 optimizer=None,\n",
     "                 optimizer_kwargs=None,\n",
+    "                 lr_scheduler=None,\n",
+    "                 lr_scheduler_kwargs=None,\n",
     "                 **trainer_kwargs):\n",
     "        super().__init__(\n",
     "            random_seed=random_seed,\n",
     "            loss=loss,\n",
     "            valid_loss=valid_loss,\n",
     "            optimizer=optimizer,\n",
     "            optimizer_kwargs=optimizer_kwargs,\n",
+    "            lr_scheduler=lr_scheduler,\n",
+    "            lr_scheduler_kwargs=lr_scheduler_kwargs,\n",
     "            futr_exog_list=futr_exog_list,\n",
     "            hist_exog_list=hist_exog_list,\n",
     "            stat_exog_list=stat_exog_list,\n",

diff --git a/neuralforecast/common/_base_multivariate.py b/neuralforecast/common/_base_multivariate.py
@@ -52,6 +52,8 @@ def __init__(
         alias=None,
         optimizer=None,
         optimizer_kwargs=None,
+        lr_scheduler=None,
+        lr_scheduler_kwargs=None,
         **trainer_kwargs,
     ):
         super().__init__(
@@ -60,6 +62,8 @@ def __init__(
             valid_loss=valid_loss,
             optimizer=optimizer,
             optimizer_kwargs=optimizer_kwargs,
+            lr_scheduler=lr_scheduler,
+            lr_scheduler_kwargs=lr_scheduler_kwargs,
             futr_exog_list=futr_exog_list,
             hist_exog_list=hist_exog_list,
             stat_exog_list=stat_exog_list,

diff --git a/neuralforecast/common/_base_recurrent.py b/neuralforecast/common/_base_recurrent.py
@@ -51,6 +51,8 @@ def __init__(
         alias=None,
         optimizer=None,
         optimizer_kwargs=None,
+        lr_scheduler=None,
+        lr_scheduler_kwargs=None,
         **trainer_kwargs,
     ):
         super().__init__(
@@ -59,6 +61,8 @@ def __init__(
             valid_loss=valid_loss,
             optimizer=optimizer,
             optimizer_kwargs=optimizer_kwargs,
+            lr_scheduler=lr_scheduler,
+            lr_scheduler_kwargs=lr_scheduler_kwargs,
             futr_exog_list=futr_exog_list,
             hist_exog_list=hist_exog_list,
             stat_exog_list=stat_exog_list,

diff --git a/neuralforecast/common/_base_windows.py b/neuralforecast/common/_base_windows.py
@@ -55,6 +55,8 @@ def __init__(
         alias=None,
         optimizer=None,
         optimizer_kwargs=None,
+        lr_scheduler=None,
+        lr_scheduler_kwargs=None,
         **trainer_kwargs,
     ):
         super().__init__(
@@ -63,6 +65,8 @@ def __init__(
             valid_loss=valid_loss,
             optimizer=optimizer,
             optimizer_kwargs=optimizer_kwargs,
+            lr_scheduler=lr_scheduler,
+            lr_scheduler_kwargs=lr_scheduler_kwargs,
             futr_exog_list=futr_exog_list,
             hist_exog_list=hist_exog_list,
             stat_exog_list=stat_exog_list,