Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: migrate theta to c++ #955

Merged
merged 4 commits into from
Dec 17, 2024
Merged

enh: migrate theta to c++ #955

merged 4 commits into from
Dec 17, 2024

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Dec 7, 2024 •
edited
Loading

Contributes to #753 by moving the jitted functions in Theta to C++.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 7, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #955 will improve performances by 20.5%

Comparing theta-cpp (d8c51d0) with main (9e05f1d)

Summary

⚡ 1 improvements
✅ 5 untouched benchmarks

Benchmarks breakdown

Benchmark main theta-cpp Change
⚡ test_efficiency[AutoTheta] 17 ms 14.1 ms +20.5%

@jmoralez jmoralez changed the title feat: migrate theta to c++ enh: migrate theta to c++ Dec 9, 2024
@jmoralez jmoralez marked this pull request as ready for review December 9, 2024 19:28
@jmoralez jmoralez requested a review from AzulGarza December 9, 2024 19:28
@jmoralez jmoralez merged commit e6cacae into main Dec 17, 2024
27 checks passed
@jmoralez jmoralez deleted the theta-cpp branch December 17, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzulGarza AzulGarza Awaiting requested review from AzulGarza

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmoralez