Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to polkadot 1.1.0 #800

Merged
merged 76 commits into from
Dec 13, 2023

Conversation

simonsso
Copy link
Contributor

@simonsso simonsso commented Nov 21, 2023

  • Verify merges
  • cargo build --release
  • cargo test
  • Benchmarks compiles
  • Weights update or ignored
  • try-runtime
  • Run local test-net
  • File tickets if metadata changed

TODO:

  • Try runtime 100 full migration warning
  • review code

simonsso and others added 30 commits September 15, 2023 14:36
Save compile errors to later.
Clean up benchmarks
Clean up type depencies
+/// Index of a transaction in the chain.
+pub type Nonce = u32;
Fix todos before merge
@simonsso simonsso mentioned this pull request Nov 21, 2023
10 tasks
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 536 lines in your changes are missing coverage. Please review.

Comparison is base (fa2f0f2) 65.63% compared to head (a3de301) 65.70%.

Files Patch % Lines
runtimes/eden/src/weights/pallet_identity.rs 0.00% 80 Missing ⚠️
runtimes/eden/src/weights/pallet_uniques.rs 0.00% 60 Missing ⚠️
pallets/sponsorship/src/weights.rs 18.75% 52 Missing ⚠️
pallets/uniques/src/weights.rs 0.00% 36 Missing ⚠️
runtimes/eden/src/weights/pallet_scheduler.rs 0.00% 35 Missing ⚠️
runtimes/eden/src/weights/pallet_multisig.rs 0.00% 34 Missing ⚠️
...imes/eden/src/weights/pallet_collator_selection.rs 0.00% 33 Missing ⚠️
runtimes/eden/src/weights/pallet_membership.rs 0.00% 28 Missing ⚠️
runtimes/eden/src/weights/pallet_preimage.rs 0.00% 28 Missing ⚠️
runtimes/eden/src/weights/pallet_xcm.rs 0.00% 28 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
+ Coverage   65.63%   65.70%   +0.06%     
==========================================
  Files          50       50              
  Lines       11414    11460      +46     
==========================================
+ Hits         7492     7530      +38     
- Misses       3922     3930       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonsso
Copy link
Contributor Author

The deprecation warnings https://github.com/NodleCode/chain/actions/runs/7177875490/job/19545056466?pr=800
image

This change will open a can of worms. Our code is same as cumulus/parachain-template/node/src/service.rs and chaning this to paritytech/cumulus#2300 will require a full integration of async backing. Which I think should be handeled in a separeate PR CHA-395

@simonsso
Copy link
Contributor Author

  • Check this, why was weights not build
  error[E0599]: no function or associated item named `initiate_reserve_withdraw` found for struct `pallet_xcm_benchmarks_generic::WeightInfo` in the current scope
     --> /home/fredrik_nodle_com/chain/runtimes/eden/src/weights/mod.rs:184:26
      |
  184 |         XcmGeneric::<Runtime>::initiate_reserve_withdraw()
      |                                ^^^^^^^^^^^^^^^^^^^^^^^^^ function or associated item not found in `WeightInfo<Runtime>`
      |
     ::: /home/fredrik_nodle_com/chain/runtimes/eden/src/weights/pallet_xcm_benchmarks_generic.rs:46:1
      |
  46  | pub struct WeightInfo<T>(PhantomData<T>);
      | ------------------------ function or associated item `initiate_reserve_withdraw` not found for this struct
      |
      = help: items from traits can only be used if the trait is implemented and in scope
      = note: the following traits define an item `initiate_reserve_withdraw`, perhaps you need to implement one of them:
              candidate #1: `staging_xcm::v2::XcmWeightInfo`
              candidate #2: `cumulus_primitives_core::XcmWeightInfo`

  For more information about this error, try `rustc --explain E0599`.
  error: could not compile `runtime-eden` (lib) due to previous error

@simonsso simonsso changed the base branch from master to feature_integrate_upgrade December 13, 2023 06:29
@simonsso simonsso merged commit cb370ea into feature_integrate_upgrade Dec 13, 2023
4 of 7 checks passed
@simonsso simonsso deleted the iso/upgrade_to_polkadot_1_1_0 branch December 13, 2023 06:31
simonsso added a commit that referenced this pull request Mar 14, 2024
* Upgrade to polkadot 1.1.0 (#800)
* Upgrade towards 1.1.0
* Update CI version
* polkadot 1.1 dependencies
* Merge updates for benchmarks
* upgrade to polkadot 1.2.1 (#804)
* Upgrade to 1.2.0  integrate PreImage Pallet
* Test cases remove deprecated calls
* Upgrade to polkadot 1.3.0
* ORML force update
* Benchmark tests
* Migration for pallet_uniques
* Remove Clippy Warnings
* Remove dead code
* Upgrade to polkadot 1.4.0 (#814)
* Remove ReachableDest
* XCM config
* Use define_benchmarks!
* upgrade to polkadot 1.5.0 (#816)
* Upgrade to 1.5.0
* Remove migrations completed in Spec 27
* Use release tag
* Upgrade to 1.6.0
* Upgrade calls to 1.6.0 API
* Dwellir hostname change
* Update weights
* Update service.rs and command.rs from latest template
* Workspace dependencies
* Get substrate from crates.io
* Storage migrations
* Reintegrate orml
* Silence warning
* Cargo.toml reformat
* Fix failing benchmarks
* XCM benchmarks
* Clippy
* CI srtool
* Update weights
* Use benchmark for reserve_asset_deposited()
* Use only two collators for dev nets
* SR tool version
* Update runtimes/eden/src/pallets_parachain.rs
* Update runtimes/eden/src/pallets_util.rs
* Update node/src/command.rs
* Use Polkadot ED
* Integrate proxy pallet
* Add pallet_proxy benchmarks
* Separate weights for all pallets
* Code cleanup
* Benchmarks
* Auto fmt
* Refactor benchmark script
* feat(nodle-parachain): use wasm executor
* Remove sponsorship migration
* Default ports Relay chain default rpc port different from parachain default port
* Docker example in Readme verified to work
* The docker example uses all necessary parameters. Is readable and runable at the same time.
* Set base delivery fee in DOT derived constant


close CHA-407
close #738
close #825 
close #824 

---------

Co-authored-by: Alex Sedighi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants