Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds deployment stamp modification #798

Conversation

3commascapital
Copy link

@3commascapital 3commascapital commented Aug 30, 2024

useful context is lacking from artifacts. addresses are very useful, but not sufficient for all situations, such as indexers, which often desire a start block.

this will require a docs update, which i am happy to do as soon as it is communicated that this feature is desired.

@kanej kanej force-pushed the adds-deployment-stamps branch from 736b1f3 to d319212 Compare December 13, 2024 11:23
@kanej
Copy link
Member

kanej commented Dec 13, 2024

Our apologies @3commascapital, we let this one slip through the cracks.

Providing more transaction details to enable use cases like indexing is something we want to add, if you are interested in talking through the use case and the approach in this PR you can ping us on discord.

@kanej
Copy link
Member

kanej commented Dec 18, 2024

I am going to close this PR in preparation for the port of Hardhat Ignition over to the Hardhat repo.
The discussion on this topic continued, our next steps are looking to enhancing the status command and function in core to support the extra data needed here. We will pick that discussion up in the Hardhat repo.

@kanej kanej closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants