Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix serialization of bigints in transacitons command #837

Merged
merged 4 commits into from
Nov 22, 2024
Merged

fix serialization of bigints in transacitons command #837

merged 4 commits into from
Nov 22, 2024

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Nov 20, 2024

resolves #830

@zoeyTM zoeyTM requested review from kanej and alcuadrado November 20, 2024 09:01
kanej
kanej requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a test explicitly for bigints in the parameters of a transaction.

packages/core/src/list-transactions.ts Outdated Show resolved Hide resolved
packages/core/src/list-transactions.ts Outdated Show resolved Hide resolved
@zoeyTM zoeyTM requested a review from kanej November 21, 2024 14:28
@kanej
refactor: switch to replacer function for transaction list display
af1f34b 
To ensure we work with nested parameters we use a replacer function on
stringify, rather than swapping out individual params.
kanej
kanej approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could consider exploring other ways of out putting the params in the future rather than stringify. We convert bigints to strings here in a way that may be un-intuitive to users.

@zoeyTM zoeyTM merged commit e10621b into development Nov 22, 2024
5 checks passed
@zoeyTM zoeyTM deleted the fix/bigint-txs branch November 22, 2024 05:39
@zoeyTM zoeyTM mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanej kanej kanej approved these changes

@alcuadrado alcuadrado Awaiting requested review from alcuadrado

Assignees
No one assigned
Labels
None yet
Projects
Hardhat Ignition
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New ignition transactions command is unable to serialize BigInt
2 participants
@zoeyTM @kanej