Enable ignition UI for deployments via hardhat scripts #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Zoey and I reviewed this, and decided we should add a boolean flag to control whether the UI should be displayed or not, which should default to false. We'll document this in the scripts guide, but it will work out of the box for test use cases (i.e. no unexpected output in tests). |
alcuadrado
reviewed
Dec 12, 2024
alcuadrado
approved these changes
Dec 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #839
Tested whatever situations I could think of and everything looked okay. Below is a sample output of a run on a local non-ephemeral network with an immediate follow up run that deploys nothing: