Allow importing module parameters with filepath in scripts #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcuadrado
reviewed
Dec 17, 2024
|
|
||
| import { bigintReviver } from "./bigintReviver"; | ||
|
|
||
| export async function resolveConfigPath( |
There was a problem hiding this comment.
Maybe it could be something like readDeploymentParameters? I thought this was resolving the path itself, not reading the file.
alcuadrado
approved these changes
Dec 17, 2024
zoeyTM
force-pushed
the
module-params-fix
branch
from
08933d5 to
e846079
Compare
zoeyTM
force-pushed
the
module-params-fix
branch
from
e846079 to
b73be3b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #844