Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix the update after kill test #6306

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

kanej
Copy link
Member

@kanej kanej commented Feb 17, 2025

In the CI the rerun after kill would fail non-deterministically. The test manipulates the mempool and involves waits.

The comment and initial feature suggest that the contracts should be deployed batch at a time with after, but the test does not include it. Specifically here are the reproduction steps from the original issue:

## Reproduction steps

    Update the examples/sample module to deploy 5 contracts one after the other using after (each in its own batch).
    Set the node so that automining is false and the interval to 1s.
    Start the first run and ctrl c after the first batch has started
    Rerun the deployment
    You should see the 405 error after the 3rd batch

I have added in the after and will monitor the CI to see if it deals with the non-deterministic failures.

Testing

I manually forced reruns of the entire build 5 times to check that the test did not recur. There are other non-deterministic failures (e.g. compiler downloading) but I did not see the rerun after kill test fail. This is not conclusive proof, but an improvement at the least.

In the CI the `rerun after kill` would fail non-deterministically. The
test manipulates the mempool and involves waits.

The comment and initial feature suggest that the contracts should be
deployed batch at a time with `after`, but the test does not include it.

I have added in the `after` and will monitor the CI to see if it deals
with the non-determinist failures.
Copy link

changeset-bot bot commented Feb 17, 2025

⚠️ No Changeset found

Latest commit: c4ddb87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 0:15am

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 17, 2025
@kanej kanej linked an issue Feb 17, 2025 that may be closed by this pull request
@kanej kanej added the v-next A Hardhat v3 development task label Feb 17, 2025
@kanej kanej marked this pull request as ready for review February 17, 2025 12:58
@kanej kanej enabled auto-merge February 17, 2025 12:58
@kanej kanej requested review from galargh and alcuadrado and removed request for galargh February 17, 2025 12:58
@kanej kanej added this pull request to the merge queue Feb 17, 2025
Merged via the queue into v-next with commit 8d9a32b Feb 17, 2025
33 checks passed
@kanej kanej deleted the fix/update-rerun-after-kill branch February 17, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Look at execution - rerun after kill flaky Ignition test
2 participants