test: fix the update after kill test #6306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the CI the
rerun after kill
would fail non-deterministically. The test manipulates the mempool and involves waits.The comment and initial feature suggest that the contracts should be deployed batch at a time with
after
, but the test does not include it. Specifically here are the reproduction steps from the original issue:I have added in the
after
and will monitor the CI to see if it deals with the non-deterministic failures.Testing
I manually forced reruns of the entire build 5 times to check that the test did not recur. There are other non-deterministic failures (e.g. compiler downloading) but I did not see the
rerun after kill
test fail. This is not conclusive proof, but an improvement at the least.