Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to run C-isotopes with sediment code switched on #266

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add capability to run C-isotopes with sediment code switched on #266

merged 1 commit into from
Aug 3, 2023

Conversation

JorgSchwinger
Copy link
Contributor

This is the PR that @jmaerz has mentioned in #264 - it is slightly more than "minor changes to sedshi.F90", so it will most probably create merge conflicts when merging with #264. Up to you, @mvertens to decide what order to follow when merging this, please let me know.

This PR has been tested technically but has not been validated beyond this. The build script will still refuse to run this combination of options, but it would be good to have this code in already now.

…ed technically but not validated, build script will still refuse to run this combination of options)
Copy link
Contributor

@mvertens mvertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR should go in next.

Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JorgSchwinger - It's good to get in these changes now, even though it may not be the final version.

Copy link
Collaborator

@jmaerz jmaerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @JorgSchwinger , many thanks for the effort to bring this in! Approved.

@JorgSchwinger JorgSchwinger merged commit aa737aa into NorESMhub:master Aug 3, 2023
10 checks passed
@JorgSchwinger JorgSchwinger deleted the feature-Ciso_sediments branch August 3, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants