Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci.yml with ecosys enabled #284

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Update ci.yml with ecosys enabled #284

merged 8 commits into from
Oct 17, 2023

Conversation

TomasTorsvik
Copy link
Contributor

Testing CI with ecosys

@TomasTorsvik TomasTorsvik linked an issue Oct 17, 2023 that may be closed by this pull request
CI does not work with ecosys enabled #283
Closed
@TomasTorsvik
Restore restart_trcrd.F90 from release-1.3
666b1e4 
Building BLOM stand-alone without iHAMOCC is does not allow any
references to hamocc functions. For now, it's more convenient to restore
'ifdef HAMOCC' when used in BLOM.
@TomasTorsvik
Revert to old run test
ef267ca 
Something went wrong when trying to add condition on openmpm starting
test runs for all configurations.
@TomasTorsvik
Add ecosys test with gnu compilers
2b006d3
@TomasTorsvik
Fix typo
be7a9b1
@TomasTorsvik TomasTorsvik self-assigned this Oct 17, 2023
@TomasTorsvik TomasTorsvik added CI/meson Issues related to CI builds and/or meson enhancement New feature or request iHAMOCC Issue mainly concerns the iHAMOCC code base and removed enhancement New feature or request labels Oct 17, 2023
@TomasTorsvik
Copy link
Contributor Author

TomasTorsvik commented Oct 17, 2023 •
edited
Loading

Enabling ecosys for the gnu compiler build returns lots of strange error of the type:

../hamocc/accfields.F90:450:14:

  450 |           if (GLB_INVENTORY(l).ne.0) then
      |              1
Error: Function ‘glb_inventory’ at (1) has no IMPLICIT type

No idea why this happens for variables imported from modules, and don't have time to look into it now. It seems to work OK for the intel compiler. I have disabled building with ecosys for the gnu compiler for now, so the checks are passed.

@TomasTorsvik
Copy link
Contributor Author

I had to restore the old restart_trcrd.F90 with the #ifdef HAMOCC statements to get it through the intel compilation tests. Somehow, it's strange that it passed with the gnu compiler even though hamocc_init was missing.

jmaerz
jmaerz approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@jmaerz jmaerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@TomasTorsvik TomasTorsvik merged commit 17b7bb6 into NorESMhub:master Oct 17, 2023
12 checks passed
@TomasTorsvik TomasTorsvik deleted the ci_for_ecosys branch October 17, 2023 12:52
@jmaerz jmaerz mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvertens mvertens mvertens approved these changes

@jmaerz jmaerz jmaerz approved these changes

@matsbn matsbn Awaiting requested review from matsbn

@JorgSchwinger JorgSchwinger Awaiting requested review from JorgSchwinger

Assignees

@TomasTorsvik TomasTorsvik

Labels
CI/meson Issues related to CI builds and/or meson iHAMOCC Issue mainly concerns the iHAMOCC code base
Projects
NorESM Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI does not work with ecosys enabled
3 participants
@TomasTorsvik @mvertens @jmaerz