Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use only submodules for noresm checkout #407

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

mvertens
Copy link
Contributor

This PR does several things.

  1. In preparation for moving to git-fleximod (which uses simply an extended version of the .gitmodules file) Externals_BLOM.cfg was removed. manage_externals will still be used - but it will only look at the .gitmodules file.
  2. It is preferable to use https in .gitmodules rather than ssh because ssh requires you to have a github account, ssh keys and knowledge of using them. https is used across the rest of NorESM and CESM - so this change will facilitate that.

@mvertens mvertens added the enhancement New feature or request label Sep 27, 2024
@mvertens mvertens added this to the NorESM2.5 - BLOM/iHAMOCC milestone Sep 27, 2024
Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Copy link
Contributor

@matsbn matsbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of years ago it seemed GitHub was recommending to go away from https and using tokens or ssh, if I remember correctly. If https still works for all practical purposes, I have no objections.

@TomasTorsvik
Copy link
Contributor

You can not push changes to github over https (or maybe it requires 2FA identification?). As long as you only check out the code it should be fine. For code developers it is probably easier to use ssh or tokens (although, I haven't really looked into the option of using tokens).

@TomasTorsvik TomasTorsvik self-assigned this Sep 27, 2024
@TomasTorsvik
Copy link
Contributor

@mvertens , @matsbn - I'm taking the liberty to merge this, and create a tag on the master branch, dev1.6.1.7 will be available shortly.

@TomasTorsvik TomasTorsvik merged commit 65e1b41 into NorESMhub:master Sep 27, 2024
5 checks passed
@mvertens
Copy link
Contributor Author

@TomasTorsvik, @matsbn - thank you for the quick response to this.

@gold2718
Copy link

You can not push changes to github over https (or maybe it requires 2FA identification?). As long as you only check out the code it should be fine. For code developers it is probably easier to use ssh or tokens (although, I haven't really looked into the option of using tokens).

You can push changes to GitHub over HTTPS. Quoting from the NorESM2.1 documentation

To upload data over HTTPS it is necessary to provide a personal access token (PAT) that can be created for a user account, which replaces the password for user authentication when pushing code to a GitHub repository.

Do we need to enhance this section?

@TomasTorsvik
Copy link
Contributor

My mistake. I just never took the time to look into the tokens option properly. The same for the github-cli option. Locally, I'm only using SSH. I have the impression that github changes the access options from time to time, so I think it's better to point to github documentation in this case.

@jmaerz
Copy link
Collaborator

jmaerz commented Sep 27, 2024

@gold2718 that means to copy github-credentials (PAT) to the HPC system, right (or is there a different way that I am unaware of)? Thus far, I also use ssh agent to access the repos. Maybe worth an edit into the docu (after testing), it seems to be easy to exchange default https@ with git@ without changing the repo using the global .gitconfig:

[url "[email protected]:"]
  insteadOf = https://github.com/

(untested thus far, though - just found it, when the question came up on my side).

@mvertens mvertens deleted the feature/use_only_submodules branch October 2, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants