Adjust pkgs meson file for transitioning M4AGO #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t version Only relevant, when compiled via meson setups
jmaerz
added
iHAMOCC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR informs about potential issues when setting up a run with meson - cime-managed runs are NOT affected.
The PR provides support for any of the current M4AGO versions provided meson >= 0.57 is used.
Background
I recently worked on the M4AGO-sinking-scheme package and introduced a new file, which requires to be explicitly set via
meson.build. Typically, a particular tag/sha of M4AGO is checked out (where this change isn't needed), but if one for any reason moves on to M4AGOmaster, this will create issues when compiling with meson. The code snippet is applicable for meson versions >=0.57, where the meson file system module has been introduced. Otherwise, the file needs to be manually added in themeson.buildfile. Hope it helps in the current transition period for M4AGO which is for making it more general and future-ready.@JorgSchwinger and @TomasTorsvik : if wished, I can push it to
master- I was just hesitant since the required meson release was Feb. 2021, which isn't too long ago.@matsbn : I put you in here explicitly, since I know that you are using meson every now and then (not sure, which meson version you're running, though).