Update Change files

doc/ChangeLog

@@ -1,7 +1,7 @@
 ===============================================================
 Tag name: ctsm5.1.dev134
 Originator(s): rgknox (Ryan Knox,LBNL EESA), erik (Erik Kluzek,UCAR/TSS,303-497-1326)
-Date: Mon Aug 14 07:19:59 PM EDT 2023
+Date: Wed Aug 16 17:20:27 MDT 2023
 One-line Summary: Migration of FATES to share normal soil BGC call sequence and functionality
 
 Purpose and description of changes
@@ -32,25 +32,28 @@ Bugs fixed or introduced
 Surprisingly, nvhpc tests are now working, but it may just be coincidental. All existing aux_clm tests are passing. Tests without FATES are b4b, with roundoff differences in just TOTCOLC and TOTCOLN.
 
 CTSM issues fixed (include CTSM Issue #):
-
-Known bugs introduced in this tag (include issue #):
+   We think #1879 -- "AD spinup issues for FATES", is fixed but haven't proved it
+   #2112 -- black check on SystemTest file
 
 Notes of particular relevance for users
 ---------------------------------------
 A CLM-FATES simulation will turn on nitrogen supplementation, this enables sufficient immobilization and decomposition. Until FATES and CLM can handle fully coupled nitrogen exchange, which would include root uptake of the mineralized aqueous forms (NH4 and NO3), N limitations in the soil are meaningless when FATES is on.
 
 Caveats for users (e.g., need to interpolate initial conditions):
-
-Changes to CTSM's user interface (e.g., new/renamed XML or namelist variables):
+    FATES MUST have suplnitro='ALL' now (was NONE). When fates_parteh_mode>=1 other settings are allowed.
+    More checking for use_luna and suplnitro is added for FATES in the build-namelist
 
 Changes made to namelist defaults (e.g., changed parameter values): FATES runs now supplement N
+   suplnitro set to ALL for FATES
+   use_luna set to .false. for FATES and clm4_5 physics
 
-Changes to the datasets (e.g., parameter, surface or initial files):
-
-Substantial timing or memory changes:
-[e.g., check PFS test in the test suite and look at timings, if you
-expect possible significant timing changes]
+Notes of particular relevance for developers:
+---------------------------------------------
 
+Caveats for developers (e.g., code that is duplicated that requires double maintenance):
+    We should update defaults for suplnitro, when Nitrogen nutrients are allowed in FATES
+    The black checdk github action has to duplicate actions for each source file or directory
+    We should move to using the Makefile in the python directory when we figure it out
 
 Testing summary:
 ----------------
@@ -64,7 +67,7 @@ cheyenne: OK  /glade/scratch/rgknox/tests_0814-134713ch
 Answer changes
 --------------
 
-Changes answers relative to baseline:
+Changes answers relative to baseline: Two diganostic fields (TOTCOLC and TOTCOLN)
 
 Baseline changes will be reported for many tests, all tests were combed to identify RMS diffs, all non-FATES tests had at most, roundoff level (<e-12) diffs in TOTCOLC and TOTCOLN.  FATES tests have diffs due to the subtle but unavoidable differences in how the models are coupled.
 

doc/ChangeSum

@@ -1,6 +1,6 @@
 Tag                   Who      Date  Summary
 ============================================================================================================================
-    ctsm5.1.dev134   rgknox 08/14/2023 Migration of FATES to share normal soil BGC call sequence and functionality
+    ctsm5.1.dev134   rgknox 08/16/2023 Migration of FATES to share normal soil BGC call sequence and functionality
     ctsm5.1.dev133 glemieux 08/09/2023 FATES API update to facilitate fates refactor
     ctsm5.1.dev132   slevis 08/04/2023 Add parameterization to allow excess ice in soil and subsidence
     ctsm5.1.dev131 samrabin 07/27/2023 Enable prescribed crop calendars