Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put in changes needed for addition of new dglc component #72

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

mvertens
Copy link

@mvertens mvertens commented Apr 1, 2024

Description of changes

change needed for the addition of a dglc component in cdeps

Specific notes

This minor change to buildnml is needed in order to support the addition of dglc which will replace CISM running in noevolve mode.
This will enable having many of the current CTSM tests that use SGLC move to using DGLC%NOEVOLVE.

Contributors other than yourself, if any: None

CTSM Issues Fixed: None

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any:
Ran a test case with
compset 1850_DATM%GSWP3v1_CLM50%SP_SICE_SOCN_SROF_DGLC%NOEVOLVE_SWAV and resolution f10_f10_ais8gris4_mg37
and compared to
compset 1850_DATM%GSWP3v1_CLM50%SP_SICE_SOCN_SROF_CISM%NOEVOLVE_SWAV and resolution f10_f10_ais8gris4_mg37

@mvdebolskiy mvdebolskiy self-requested a review April 2, 2024 10:41
@mvertens
Copy link
Author

mvertens commented Apr 2, 2024

@mvdebolskiy - if you okay with this PR can you please accept the review and merge it (or I'm happy to merge it).

@mvertens
Copy link
Author

mvertens commented Apr 2, 2024

Also - I don't understand why black is failing. With the changes I've put in - it passes for ESCOMP and there is no statement as to what the failure is.

@mvdebolskiy
Copy link
Collaborator

Also - I don't understand why black is failing. With the changes I've put in - it passes for ESCOMP and there is no statement as to what the failure is.

No idea. But maybe the version of black or config for black is more relaxed now at ESCOMP. I've fixed the extra lines, so now it passes.

@mvdebolskiy mvdebolskiy merged commit b84a944 into NorESMhub:noresm Apr 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants