Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry deposition working with FATES-NOCOMP #11

Draft
wants to merge 12 commits into
base: noresm
Choose a base branch
from

Conversation

rosiealice
Copy link
Collaborator

These are the FATES-side changed for making FATES-NOCOMP mode work with dry deposition.

The noresm branch appears to be somewhat behind the FATES main, hence the large number of apparent differences.

This code runs in coupled mode and produces valid outputs. Analysis of the validity of their magnitudes is ongoing.

A follow-up PR will introduce the scientifically useful calculation of the seasons. This PR is just to make the code function at all.

Description:

Collaborators:

@mvdebolskiy
@mvertens
@maritsandstad
@kjetilaas

Expectation of Answer Changes:

Answers are expected to change, but only for the dry deposition fields. It is hard to assess the impact of these answer changes as these fields were not generated before and the model version that generates them did not function prior to this PR.
But nothing else should change except for the dry deposition fields.

Checklist:

  • My change requires a change to the documentation. (not until it becomes a PR on the actual FATES repo.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided. Answers are expected to change.

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@rosiealice rosiealice marked this pull request as draft October 14, 2024 10:55
@mvertens
Copy link

@rosiealice - I think it would not be easier to make 2 PRs here.

  • PR1 would be just to bring the FATES no NorESM up to date with FATES main.
  • PR2 would be to update PR1 to have the drydep changes you introduced. That way it would be straightforward to review the changes you made rather than trying to understand this in the context of 147 file changes.
  • What tests should be run for PR1 and PR2? Should we try using the new testlist I suggested? We need to create baselines here for that. It would be really helpful to get feedback on if that testlist is too big, etc. Thoughts?

@rosiealice
Copy link
Collaborator Author

Yes, it would be good to bring noresm up to date with NGEET/ FATES main. For some reason I could not see the noresm branch this morning, but I do think it would be better if there was another PR before this one to update it. I can try and have a go...

Note that the NorESMhub/CTSM tags we are using currently point to a NGEET/FATES tag and not here.. https://github.com/NorESMhub/NorESM/blob/noresm2_5_alpha06/Externals_CLM.cfg

@rosiealice rosiealice changed the base branch from master to noresm October 15, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants