-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix types export for astro 3 and typescript 5 #74
fix types export for astro 3 and typescript 5 #74
Conversation
Hey @jsve, thank you for your pull request 🙏 I see, we missed handling types correctly and I can reproduce it locally: Also, found how storyblok/astro solved it https://github.com/storyblok/storyblok-astro/pull/454/files This to address:
import type { RichTextType } from "storyblok-rich-text-astro-renderer"; instead of current:
? And I am almost certainly sure the Thanks. |
a419c37
to
15f936c
Compare
Thanks for reviewing! I did the changes and the commit from the web interface, hence the missing DCO. That also meant that I didn't get prettier and the other helpers. Sry! I cleaned up the code now. Also had to modify the ts-config ref with I agree that the |
16c0081
to
a062d65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 love it!
One more small bit though @jsve, we do not have squash and merge enabled (maybe it would be a good idea to consider), since we use semantic-release (not quite finished, some bits needed for CHANGELOG generating and CI) in the meantime, I would like you to squash your changes into single commit ( |
a062d65
to
7be7425
Compare
Signed-off-by: Johan Svensson <[email protected]>
7be7425
to
115c64f
Compare
no problem! Definitely sounds like you should enable squash and merge :) I used your suggested commit message in the squashed commit. Shouldn't it be |
You are right! Let's make a proper major release then. We can explain the breaking change, thus the commit may be either with
|
Awesome! Thanks for helping me navigate your git-process :) Do you have any plans for when the next release will be out? I'm guessing I'm not the only one who has had to move to astro 3. |
It's out 🎉 https://www.npmjs.com/package/storyblok-rich-text-astro-renderer |
In addition to this it seems like type declarations also needs to be updated for the component to be imported without TS issues.
This PR replicates the component export process from @storyblok/astro