fix types export for astro 3 and typescript 5

[jsve]

In addition to this it seems like type declarations also needs to be updated for the component to be imported without TS issues.

This PR replicates the component export process from @storyblok/astro

[edvinasjurele]

Hey @jsve, thank you for your pull request 🙏

I see, we missed handling types correctly and I can reproduce it locally:

Also, found how storyblok/astro solved it https://github.com/storyblok/storyblok-astro/pull/454/files

---

This to address:

1. DCO. Please check your commit signing
2. Could you please fix the demo/src/pages/index.astro to have the following:

import type { RichTextType } from "storyblok-rich-text-astro-renderer";

instead of current:

import type { RichTextType } from "storyblok-rich-text-astro-renderer/RichTextRenderer.astro";

? And I am almost certainly sure the export type { RichTextType }; is redundant in the RichTextRenderer.astro from now on too, because RichTextRenderer.ts file covers the importing bits instead, and not .astro anymore.

Thanks.

[jsve]

Thanks for reviewing!

I did the changes and the commit from the web interface, hence the missing DCO. That also meant that I didn't get prettier and the other helpers. Sry!

I cleaned up the code now. Also had to modify the ts-config ref with jsx: preserve.

I agree that the export type is redundant in the RichTextRenderer.astro. It makes more sense to get all types from the actual types. I made the corresponding change in the readme as well.

[edvinasjurele]

👏 love it!

[edvinasjurele]

One more small bit though @jsve, we do not have squash and merge enabled (maybe it would be a good idea to consider), since we use semantic-release (not quite finished, some bits needed for CHANGELOG generating and CI) in the meantime, I would like you to squash your changes into single commit (fix: improve types export for astro 3 and typescript 5) please 🙏

[jsve]

no problem! Definitely sounds like you should enable squash and merge :)

I used your suggested commit message in the squashed commit. Shouldn't it be fix!: ... though? Aka breaking change? When we moved the export of the type, that potentially means that users need to modify their imports. Just a thought.

[edvinasjurele]

no problem! Definitely sounds like you should enable squash and merge :)

I used your suggested commit message in the squashed commit. Shouldn't it be fix!: ... though? Aka breaking change? When we moved the export of the type, that potentially means that users need to modify their imports. Just a thought.

You are right! Let's make a proper major release then. We can explain the breaking change, thus the commit may be either with ! mark or with that BREAKING CHANGE notice, like with explanation:

fix: improve types export for astro 3 and typescript 5

BREAKING CHANGE: The TS types imports has been changed.

[jsve]

Awesome! Thanks for helping me navigate your git-process :)

Do you have any plans for when the next release will be out? I'm guessing I'm not the only one who has had to move to astro 3.

[edvinasjurele]

Awesome! Thanks for helping me navigate your git-process :)

Do you have any plans for when the next release will be out? I'm guessing I'm not the only one who has had to move to astro 3.

It's out 🎉 https://www.npmjs.com/package/storyblok-rich-text-astro-renderer
Let me know if anything is missing. Happy coding!