C library: Change usage of strlen to use strnlen #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
requested review from
hakonfam,
sigvartmh,
busserull and
FilipZajdel
|
Seems for some targets(1 target) it doesn't exist. Maybe check for libc version with this change? |
sigvartmh
approved these changes
Jul 7, 2023
FilipZajdel
approved these changes
Jul 20, 2023
Add a maxlen argument to the _term functions. Signed-off-by: Øyvind Rønningstad <[email protected]>
Some tests needed NEWLIB to get certain features. NEWLIB doesn't work well when using strnlen, so switch to PICOLIB. Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
remove-strlen
branch
from
fb0a9b8
to
c244845
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a maxlen argument to the _term functions.