Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the check for ":0@0" in CLUSTER NODES result #199

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix the check for the 'ip:port@cport' part when parsing a line in the…
… 'cluster nodes' result. The current implementation assumes that the entire part is only 2 characters when the IP and port are not set (IP is empty and port is 0). However, this is incorrect because the '@cport' is also present so the current check fails. Additionally, there may be an optional ',hostname' as well which is not accounted for.
KevinLussier-Netskope committed Jan 3, 2024
commit ff3cd2032d42257dc56ccc3f3dee9a8daa9d667a
4 changes: 2 additions & 2 deletions hircluster.c
Original file line number Diff line number Diff line change
@@ -960,8 +960,8 @@ dict *parse_cluster_nodes(redisClusterContext *cc, char *str, int str_len,
goto error;
}

// the address string is ":0", skip this node.
if (sdslen(part[1]) == 2 && strcmp(part[1], ":0") == 0) {
// if the address string starts with ":0", skip this node.
if (sdslen(part[1]) >= 2 && part[1][0] == ':' && part[1][1] == '0') {
sdsfreesplitres(part, count_part);
count_part = 0;
part = NULL;