Setup compiler and CMake in CI using a new Github Action #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler APT packages are sometimes removed so lets use the Github Action `aminya/setup-cpp` to setup the compiler. This action will now also install the requested CMake version.
- Use latest release of hiredis in examples to fix: warning: implicit declaration of function 'redisClusterAsyncSetConnectCallbackNC' - Check cc->err in callback instead of cc->errstr: warning: address of array 'cc->errstr' will always evaluate to 'true'
zuiderkwast
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APT packages are sometimes removed so lets use the Github Action aminya/setup-cpp to setup the compiler,
which fixes current CI issues with missing compiler. This action will also install the requested CMake version.
This PR includes the following changes: