Skip to content

Commit

Permalink
test: Only run C memory leak test for rust stable
Browse files Browse the repository at this point in the history
The valgrind will report possible leak when tokio is compiled by
rust nightly `rustc 1.83.0-nightly (9096f4faf 2024-10-05)`:

    tokio-rs/tokio#6889

The nmstate team has no knowledge base to debug memory leak in rust
nightly, hence we only run memory leak check on rust stable channel.

Signed-off-by: Gris Ge <[email protected]>
  • Loading branch information
cathay4t committed Oct 8, 2024
1 parent 2c39afa commit 62c5729
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ jobs:
run: cd rust && cargo test -- --show-output

- name: C library test
# As https://github.com/tokio-rs/tokio/issues/6889 mentioned
# rust nightly might lead to valgrind warnings, this project
# has no intention to spend time on testing rust nightly for memory leak.
if: matrix.rust_version == 'stable'
run: make clib_check

rpm_build:
Expand Down

0 comments on commit 62c5729

Please sign in to comment.