Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3074-Get Unread Announcements #3076

Merged
merged 19 commits into from
Dec 24, 2024
Merged

#3074-Get Unread Announcements #3076

merged 19 commits into from
Dec 24, 2024

Conversation

caiodasilva2005
Copy link
Contributor

@caiodasilva2005 caiodasilva2005 commented Dec 19, 2024 •
edited
Loading

Changes

  • Created endpoint for getting unread announcements
  • Updated schema to reflect data needed from slack events
  • Refactored all finishline notifications to be called pop-ups to avoid name conflict with slack notifications

Notes

  • the createAnnouncements service function is called when we receive a message in a slack thread

Screenshots

image

To Do

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3074

Peyton-McKee
Peyton-McKee requested changes Dec 20, 2024
View reviewed changes
src/backend/src/routes/users.routes.ts Outdated Show resolved Hide resolved
src/backend/src/services/users.services.ts Outdated Show resolved Hide resolved
src/backend/src/services/users.services.ts Outdated Show resolved Hide resolved
src/backend/src/services/announcement.service.ts Show resolved Hide resolved
src/backend/src/services/announcement.service.ts Outdated Show resolved Hide resolved
@caiodasilva2005 caiodasilva2005 self-assigned this Dec 20, 2024
walker-sean
walker-sean previously requested changes Dec 20, 2024
View reviewed changes
src/backend/src/routes/users.routes.ts Outdated Show resolved Hide resolved
src/backend/src/transformers/announcements.transformer.ts Show resolved Hide resolved
Peyton-McKee
Peyton-McKee previously approved these changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can merge after making this change, dont forget to update frontend

src/backend/src/routes/notifications.routes.ts Outdated Show resolved Hide resolved
@caiodasilva2005 caiodasilva2005 dismissed walker-sean’s stale review December 22, 2024 12:53

changes were resolved

@Peyton-McKee Peyton-McKee merged commit 505e858 into feature/homepage-redesign Dec 24, 2024
4 checks passed
@Peyton-McKee Peyton-McKee deleted the #3074-GetUnreadAnnouncements branch December 24, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peyton-McKee Peyton-McKee Peyton-McKee approved these changes

@walker-sean walker-sean walker-sean left review comments

Assignees

@caiodasilva2005 caiodasilva2005

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caiodasilva2005 @Peyton-McKee @walker-sean