#3169 getparttags endpoint #3207
Conversation
chpy04
changed the base branch from
develop
to
feature/cad-project-file-review
| static async getAllPartTags(organizationId: string) { | ||
| const organization = await prisma.organization.findUnique({ | ||
| where: { organizationId } | ||
| }); |
There was a problem hiding this comment.
Because the organization is pulled from the request and not an input from the user, you don't need to check for a notFoundException here. If the organization id for whatever reason did not exist here, it would be a problem on our end not the requester's end. Instead you can just get rid of this check
| return prisma.partTag.findMany({ | ||
| where: { organizationId }, | ||
| select: { | ||
| partTagId: true, |
There was a problem hiding this comment.
don't need to include partTagId: true here
| name: string; | ||
| colorHexCode: string; | ||
| dateCreated: Date; | ||
| dateDeleted?: Date; |
There was a problem hiding this comment.
Don't include dateDeleted in the shared type. If it was deleted, people should not be seeing it on the frontend
| } | ||
|
|
||
| return prisma.partTag.findMany({ | ||
| where: { organizationId }, |
There was a problem hiding this comment.
Only return partTags where dateDeleted is null
| const partTags = await OrganizationsService.getAllPartTags(organizationID); | ||
| expect(partTags.length).toEqual(2); | ||
| expect(partTags.some((tag) => tag.partTagId === '123')).toBeTruthy(); | ||
| expect(partTags.some((tag) => tag.partTagId === '456')).toBeTruthy(); |
There was a problem hiding this comment.
Add a partTag to a different organization, and a partTag that is deleted, and check that these are not in the result
Changes
Added new route at /organizations/getAllPartTags for #3169
Added service function using given organization id and returns an array of part tags.
Added a controller and parts-review.types.ts in shared types
Unit Tests
Notes
Could not do extensive postman tests, but unit tests passed
Test Cases
No organizationId, empty parts array, array with 2 parts
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3169