test: update test for reject_land and update fn #115
+270
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fishonamos ready for review. |
fishonamos
reviewed
Oct 31, 2024
Comment on lines
392
to
419
| fn test_can_reject_land_by_owner() { | ||
| let contract_address = deploy("LandRegistryContract"); | ||
| let land_register_dispatcher = ILandRegistryDispatcher { contract_address }; | ||
|
|
||
| // Set up test data | ||
| let owner_address = starknet::contract_address_const::<0x123>(); | ||
| let inspector_address = starknet::contract_address_const::<0x456>(); | ||
| let location = Location { latitude: 1, longitude: 2 }; | ||
| let area = 1000; | ||
| let land_use = LandUse::Residential; | ||
|
|
||
| // Register land as owner | ||
| start_cheat_caller_address(contract_address, owner_address); | ||
| let land_id = land_register_dispatcher.register_land(location, area, land_use); | ||
|
|
||
| // Verify initial status | ||
| let land_before = land_register_dispatcher.get_land(land_id); | ||
| assert_eq!(land_before.status, LandStatus::Pending, "Should be pending before reject"); | ||
|
|
||
| // Owner rejects their own land | ||
| land_register_dispatcher.reject_land(land_id); | ||
|
|
||
| // Verify final status | ||
| let land_after = land_register_dispatcher.get_land(land_id); | ||
| assert_eq!(land_after.status, LandStatus::Rejected, "Should be rejected after"); | ||
|
|
||
| stop_cheat_caller_address(contract_address); | ||
| } |
There was a problem hiding this comment.
Only inspectors should be able to reject land
There was a problem hiding this comment.
Basically, below is the process follow:
Register Land
Approve or Reject Land --- Inspector only
If appproved land, land nft is minted. Else, land is rejected. Only approved lands are valid and issued with NFts. Unapproved lands have the id as reference but don't have an associtated nft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Information
Update test file to implement test for reject_land and update_land fn
Related Issues
Closes #50
Type of Change
Checklist (select as many as applicable)