Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/main' into add-mini-nvim
Browse files Browse the repository at this point in the history
  • Loading branch information
LilleAila committed Jan 16, 2025
2 parents 952a3f1 + 45a6d9b commit 0f03d3c
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 15 deletions.
26 changes: 14 additions & 12 deletions docs/manual/hacking/guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,11 @@ necessarily) before you start developing.

## Adding Documentation {#sec-guidelines-documentation}

Most, if not all, changes warrant changes to the documentation. Module options
should be documented with
[Nixpkgs-flavoured Markdown](https://nixos.org/manual/nixpkgs/unstable/#sec-contributing-markup),
albeit with exceptions.
[Nixpkgs Flavoured Markdown]: https://github.com/NixOS/nixpkgs/blob/master/doc/README.md#syntax

::: {.note} As of **v0.5**, **nvf** is itself documented using full markdown in
both module options and the manual. With **v0.6**, this manual has also been
converted to markdown in full. :::
Almost all changes warrant updates to the documentation: at the very least, you
must update the changelog. Both the manual and module options use
[Nixpkgs Flavoured Markdown].

The HTML version of this manual containing both the module option descriptions
and the documentation of **nvf** (such as this page) can be generated and opened
Expand Down Expand Up @@ -117,10 +114,11 @@ applies to string literals and module descriptions and documentation.

### Nix {#sec-code-style-nix}

**nvf** is formatted by the
[alejandra](https://github.com/kamadorueda/alejandra) tool and the formatting is
checked in the pull request and push workflows. Run the `nix fmt` command inside
the project repository before submitting your pull request.
[alejandra]: https://github.com/kamadorueda/alejandra

**nvf** is formatted by the [alejandra] tool and the formatting is checked in
the pull request and push workflows. Run the `nix fmt` command inside the
project repository before submitting your pull request.

While Alejandra is mostly opinionated on how code looks after formatting,
certain changes are done at the user's discretion based on how the original code
Expand All @@ -138,10 +136,14 @@ module = {
# same as parent modules, unfold submodules
subModule = {
# this is an option that contains more than one nested value
# Note: try to be careful about the ordering of `mkOption` arguments.
# General rule of thumb is to order from least to most likely to change.
# This is, for most cases, type < default < description.
# Example, if present, would be between default and description
someOtherValue = mkOption {
type = lib.types.bool;
description = "Some other description";
default = true;
description = "Some other description";
};
};
}
Expand Down
13 changes: 10 additions & 3 deletions docs/release-notes/rl-0.8.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@

[horriblename](https://github.com/horriblename):

[aerial.nvim](https://github.com/stevearc/aerial.nvim)
[nvim-ufo](https://github.com/kevinhwang91/nvim-ufo)
[aerial.nvim]: (https://github.com/stevearc/aerial.nvim)
[nvim-ufo]: (https://github.com/kevinhwang91/nvim-ufo)

- Add [aerial.nvim]
- Add [nvim-ufo]
Expand All @@ -52,7 +52,8 @@
- Remove `vim.notes.obsidian.setupOpts.dir`, which was set by default. Fixes
issue with setting the workspace directory.
- Add `vim.snippets.luasnip.setupOpts`, which was previously missing.
- Add `"prettierd"` as a formatter option in `vim.languages.markdown.format.type`.
- Add `"prettierd"` as a formatter option in
`vim.languages.markdown.format.type`.

[kaktu5](https://github.com/kaktu5):

Expand All @@ -63,3 +64,9 @@
[solargraph]: https://github.com/castwide/solargraph

- Add Ruby support under `vim.languages.ruby` using [solargraph].

[thamenato](https://github.com/thamenato):

[ruff]: (https://github.com/astral-sh/ruff)

- Add [ruff] as a formatter option in `vim.languages.python.format.type`.
18 changes: 18 additions & 0 deletions modules/plugins/languages/python.nix
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,24 @@
)
'';
};

ruff = {
package = pkgs.writeShellApplication {
name = "ruff";
runtimeInputs = [pkgs.ruff];
text = ''
ruff format -
'';
};
nullConfig = ''
table.insert(
ls_sources,
null_ls.builtins.formatting.ruff.with({
command = "${cfg.format.package}/bin/ruff",
})
)
'';
};
};

defaultDebugger = "debugpy";
Expand Down

0 comments on commit 0f03d3c

Please sign in to comment.