Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: custom plugin setup options #238

Merged
merged 33 commits into from
Apr 7, 2024

Conversation

horriblename
Copy link
Collaborator

@horriblename horriblename commented Mar 3, 2024

#192, take two. idk why I split off the original PR into a hundred tiny PRs

TODO

  • use toLuaObject instead of expToLua
  • docs on nvim.types.rawLua

progress (by directories in modules/)

  • assistant

    • copilot
  • autopairs

    • nvim-autopairs
  • basic**

  • comments

    • comment-nvim
  • completion

    • nvim-cmp (need rawLua)
  • core**

  • dashboard

    • alpha
    • dashboard-nvim*
    • startify**
  • debugger

    • nvim-dap**
    • dap-ui *
  • filetree

    • nvimtree
  • git *

  • languages (need rawLua)

    • bash
    • dart
    • elixir
    • markdown
    • tidal
    • ...
  • lsp

    • lightbulb*
    • lspconfig**
    • lspkind**
    • lsplines*
    • lspsaga**
    • lsp-signature
    • null-ls (need rawLua)
    • nvim-code-action-menu**
    • nvim-docs-view
    • trouble**
  • minimap

    • codewindow*
    • minimap-vim **
  • notes

    • mind-nvim *
    • obsidian
    • orgmode
    • todo-comments
  • projects

    • project-nvim
  • rich-presence

    • neocord
  • session

    • nvim-session-manager
  • snippets

    • vsnip
  • statusline

    • lualine
  • tabline

    • nvim-bufferline*
  • terminal

    • toggleterm
  • theme

  • treesitter*

  • ui

    • borders
    • breadcrumbs
    • colorizer
      • FIXME: filetypes does not seem to work?
    • illuminate*
    • modes
    • noice*
    • notifications
    • nvim-notify
      • smartcolumn
  • utility

    • binds

      • cheatsheet*
      • which-key
    • filetree

      • nvimtree-lua
    • ccc*

    • diffview*

    • gestures

      • gesture-nvim*
    • icon-picker*

    • motion

      • hop*
      • leap*
    • treesitter-textobjects

    • preview

      • glow*
      • markdown-preview**
    • surround*

    • telescope

    • wakatime**

  • visuals

    • fidget-nvim

*no breaking changes: I won't add it for now, since they can be easily added later
**nothing to do

@horriblename horriblename marked this pull request as draft March 3, 2024 11:11
@horriblename horriblename marked this pull request as draft March 3, 2024 11:11
@horriblename horriblename marked this pull request as draft March 3, 2024 11:11
@NotAShelf NotAShelf changed the title feat: custom plugin setup options treewide: custom plugin setup options Mar 6, 2024
@NotAShelf NotAShelf added this to the 0.6 milestone Mar 6, 2024
@horriblename
Copy link
Collaborator Author

:trollface:

@horriblename horriblename force-pushed the setupopts branch 10 times, most recently from 1f87b14 to cdc483c Compare March 16, 2024 10:56
@horriblename horriblename force-pushed the setupopts branch 3 times, most recently from 33062a9 to 478bd3e Compare March 22, 2024 11:33
@horriblename horriblename marked this pull request as ready for review March 22, 2024 11:33
@NotAShelf NotAShelf mentioned this pull request Apr 6, 2024
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems to be working fine from my testing, but I'll daily drive it for a while after it's merged to v0.6.

Before I merge, could you add changelog entries for setupopts and the removal of nvim-compe? Would also be neat if you could describe the usage of setupOpts in the hacking section of the manual - but that's not critical.

@NotAShelf NotAShelf requested a review from FrothyMarrow April 6, 2024 16:20
Having users to use setupOpts for lualine would suck since lualine uses
the `{"module", option = value} lua syntax heavily and we don't have a
good syntax for that
@horriblename horriblename force-pushed the setupopts branch 2 times, most recently from 15bdd7c to 11848d0 Compare April 6, 2024 18:17
@NotAShelf NotAShelf merged commit e1835f6 into NotAShelf:v0.6 Apr 7, 2024
7 checks passed
@horriblename horriblename deleted the setupopts branch June 27, 2024 08:04
bloxx12 pushed a commit to bloxx12/nvf that referenced this pull request Sep 29, 2024
treewide: custom plugin setup options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants