Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languages/zig: Added dap support #581

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

ArmandoCIII
Copy link
Contributor

@ArmandoCIII ArmandoCIII commented Jan 24, 2025

Implemented DAP support for zig. Included comment regarding redundant dap.adapters.lldb code when both clang and zig dap modules are enabled. Redundant code does NOT break when both clang and zig dap are enabled during tests.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

Implemented DAP support for zig. Included comment regarding redundant
`dap.adapters.lldb` code when both clang and zig dap modules are
enabled.
github-actions bot pushed a commit that referenced this pull request Jan 24, 2025
Copy link

github-actions bot commented Jan 24, 2025

🚀 Live preview deployed from 547cbd2

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: feature/zig-dap-lldb

Reruns: 126

Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small nitpick for the sake of consistency.

Cleaned up code from the zig dap implementation for consistency.
@NotAShelf NotAShelf merged commit 547cbd2 into NotAShelf:main Jan 25, 2025
13 checks passed
Copy link

✅ Preview has been deleted successfully!

github-actions bot pushed a commit that referenced this pull request Jan 25, 2025
@ArmandoCIII ArmandoCIII deleted the feature/zig-dap-lldb branch January 25, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants