-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar collection view #369
base: master
Are you sure you want to change the base?
Calendar collection view #369
Conversation
- Added calendar view to Collection view exports - Base calendar, CSS inline from Notion - Pages render in the correct days - Sun-Sat week view
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- New custom Collection card for the calendar view - Show correctly the month
Improved card title, now more like the Notion one
- Now calendar controls (next month, prev month and today) works - Correctly mark current month day numbers - Display the current month correctly (top left) - Display the month in the calendar view in the first day of each month - Show full month in every view - Edit text component to show long months names - New method "getPagePropertyFromId" to retrive a page property by a given property ID, used to get the query date used by Notion calendar's view
New property for the renderer "showCalendarControls" to show or not the calendar controls (next month, prev month, today)˙
TODO: add calendar dark mode theme
- Added dark-mode css for the new calendar view - Updated background of dark-mode to the new Notion one - Moved hover states from React to CSS - Removed all dynamic styles and used with classes
Deployment failed with the following error:
|
Fix linked calendars db errors
Removed unused class
Full width for full page collection view
- Added the ability to start weeks on Monday via `startWeekOnMonday` - Made proper icons components for calendar controls
@transitive-bullshit @normdoow Everything on my to-do list is checked, and ready for PR review! |
Hey @transitive-bullshit and @normdoow I have been away for a long time from this repo and from this PR but I'm happy to say that I have made some new commits that fix your reviews and also set some features:
Edit: It doesn't currently support |
The today date indicator now check also the correct now year
Is there anything outstanding to merge this one in? |
- More comments - Fixed first day of month red background circle to not show the month name (it's shown up in the calendar controls) WIP: The October 2023 has a strange bug (probably in the algo) that shows the 1st October as Saturday and not Sunday (only on the view that has Sunday as first week day (by using `startWeekOnMonday` it doesn't appear))
Hey @kantorcodes thanks for commenting, I've to say that I've let this PR open and didn't actually take care of. |
More infos about the calendar view and what it can handle and what it can't
Thanks @MichaelCasaDev it'll be suburb to have this added in :) |
Hey @transitive-bullshit would love to see this one approved! :) |
Hey @transitive-bullshit Could you pelase merge this one this is the 1 which remain from notion block |
New Features
showCalendarControls: boolean
)startWeekOnMonday: boolean
)Description
Adding full support to the Notion calendar collection view, which lacks support in
react-notion-x
Notion Test Page ID
Page with a calendar view component