Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dev server & pnpm scripts improved #342

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Fix: dev server & pnpm scripts improved #342

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbf3b7d
fix-dev-server&pnpm-clean-improved
DimaDemchenko Mar 1, 2024
2583fa3
clean scripts
DimaDemchenko Mar 1, 2024
c5057c0
Make pnpm calls consistent across projects
mrlika Mar 1, 2024
66a1a9a
Fix json syntax
mrlika Mar 1, 2024
4b77851
Refactor linter and type check configuration
mrlika Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions demo/.eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ module.exports = {
"react-hooks/exhaustive-deps": 0,
"@typescript-eslint/no-explicit-any": 0,
},
ignorePatterns: ["public/*"],
};
4 changes: 3 additions & 1 deletion demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
"lint": "eslint src --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
"preview": "vite preview",
"prettier": "prettier --write .",
"type-check": "npx tsc --noEmit"
"type-check": "npx tsc --noEmit",
"clean": "rimraf dist",
"clean-with-modules": "rimraf node_modules && pnpm clean"
},
"dependencies": {
"dplayer": "^1.27.1",
Expand Down
2 changes: 1 addition & 1 deletion demo/public/modules-demo/demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Engine as ShakaEngine } from "p2p-media-loader-shaka";
import { Engine as HlsEngine } from "p2p-media-loader-hls";
import { Engine as HlsEngine } from "p2p-media-loader-hlsjs";
mrlika marked this conversation as resolved.
Show resolved Hide resolved

const manifestUri = "https://test-streams.mux.dev/x36xhzz/x36xhzz.m3u8";

Expand Down
2 changes: 1 addition & 1 deletion demo/public/modules-demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"imports": {
"p2p-media-loader-core": "./core/p2p-media-loader-core.es.js",
"p2p-media-loader-shaka": "./shaka/p2p-media-loader-shaka.es.js",
"p2p-media-loader-hls": "./hlsjs/p2p-media-loader-hlsjs.es.js"
"p2p-media-loader-hlsjs": "./hlsjs/p2p-media-loader-hlsjs.es.js"
}
}
</script>
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"build:es": "pnpm --filter './packages/**' run build:es",
"build:umd": "pnpm --filter './packages/**' run build:umd",
"build:umd-min": "pnpm --filter './packages/**' run build:umd-min",
"clean": "pnpm --filter './packages/**' run clean",
"clean": "pnpm --filter './packages/**' run clean && pnpm --filter './demo/**' run clean",
"clean-with-modules": "pnpm --filter './packages/**' run clean-with-modules && pnpm --filter './demo/**' run clean-with-modules",
"pack-packages": "pnpm --filter './packages/**' exec -- pnpm pack",
"lint": "pnpm --recursive run lint",
"prettier": "pnpm --recursive run prettier",
Expand Down
3 changes: 2 additions & 1 deletion packages/p2p-media-loader-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
"preview": "vite preview",
"prettier": "prettier --write .",
"lint": "eslint . --ext .ts",
"clean": "rimraf lib dist build",
"clean": "rimraf lib dist build p2p-media-loader-core-*.tgz",
"clean-with-modules": "rimraf node_modules && pnpm clean",
"type-check": "npx tsc --noEmit"
},
"dependencies": {
Expand Down
3 changes: 2 additions & 1 deletion packages/p2p-media-loader-hlsjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"preview": "vite preview",
"prettier": "prettier --write .",
"lint": "eslint . --ext .ts",
"clean": "rimraf lib dist build",
"clean": "rimraf lib dist build p2p-media-loader-hlsjs-*.tgz",
"clean-with-modules": "rimraf node_modules && pnpm clean",
"type-check": "npx tsc --noEmit"
},
"dependencies": {
Expand Down
3 changes: 2 additions & 1 deletion packages/p2p-media-loader-shaka/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"preview": "vite preview",
"prettier": "prettier --write .",
"lint": "eslint . --ext .ts",
"clean": "rimraf lib dist build",
"clean": "rimraf lib dist build p2p-media-loader-shaka-*.tgz",
"clean-with-modules": "rimraf node_modules && pnpm clean",
"type-check": "npx tsc --noEmit"
},
"dependencies": {
Expand Down