Move audit to after username change

NuGet · Dec 9, 2023 · 0158a73 · 0158a73
1 parent edd8110
commit 0158a73
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs b/src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs
@@ -123,9 +123,6 @@ public async Task<ActionResult> ChangeUsername(string oldUsername, string newUse
                 return Json(HttpStatusCode.BadRequest, "New username validation failed.", JsonRequestBehavior.AllowGet);
             }
 
-
-            await _auditingService.SaveAuditRecordAsync(new UserAuditRecord(account, AuditedUserAction.ChangeUsername));
-
             if (account.Username.Equals(newUsername, StringComparison.OrdinalIgnoreCase) == false)
             {
                 // We're doing a full username change and not just a casing change so we need to lock the old username
@@ -142,6 +139,7 @@ public async Task<ActionResult> ChangeUsername(string oldUsername, string newUse
 
             account.Username = newUsername;
 
+            await _auditingService.SaveAuditRecordAsync(new UserAuditRecord(account, AuditedUserAction.ChangeUsername));
             await _entitiesContext.SaveChangesAsync();
 
             return Json(HttpStatusCode.OK, "Account renamed successfully!", JsonRequestBehavior.AllowGet);