NuGet Job, don't rethrow exceptions if blob is not found #10188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
changed the title
erdembayar
commented
Sep 19, 2024
| catch (RequestFailedException ex) when (ex.ErrorCode == BlobErrorCode.BlobNotFound) | ||
| { | ||
| // Ignore this same as CloudBlobStorageException for below. | ||
| } | ||
| catch (CloudBlobStorageException e) | ||
| { | ||
| WebException webException = e.InnerException as WebException; |
There was a problem hiding this comment.
I didn't remove CloudBlobStorageException handling part. There could be some places we still didn't complete SDK migration. Once we have confidence, then we can remove it.
erdembayar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/NuGet/Engineering/issues/5628
Context is here on teams.
Deployment: 1550336
Previously there was many exceptions for NuGet.Jobs, after deployment it's no more.
Before:
After:
