Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NU1008.md #3331

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Update NU1008.md #3331

merged 1 commit into from
Feb 18, 2025

Conversation

RussKie
Copy link
Contributor

@RussKie RussKie commented Aug 8, 2024

Explain how to override package version

Explain how to override package version
@RussKie RussKie requested review from a team as code owners August 8, 2024 01:54
Copy link

Learn Build status updates of commit b99ae3a:

✅ Validation status: passed

File Status Preview URL Details
docs/reference/errors-and-warnings/NU1008.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:


```xml
<!-- In the project file. -->
<PackageReference Include="PackageId" VersionOverride="3.0.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a chance this might've been omitted on purpose.

While the feature is available, it's not considered a best practice.

cc @jeffkl should have more context on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a chance this might've been omitted on purpose.

We shouldn't be hiding information. It just plain wrong.

While the feature is available, it's not considered a best practice.

There are very valid scenarios for this feature - e.g., solutions targeting multiple TFMs.

Copy link
Member

@nkolev92 nkolev92 Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing "wrong" in here by not mentioning VersionOverride. The breadth of solutions offered here doesn't make it wrong.

There are very valid scenarios for this feature - e.g., solutions targeting multiple TFM

PackageVersion can be conditioned as well.

I'm not against accepting a changing like this, but I don't agree that not having it is incorrect.

@nkolev92 nkolev92 merged commit 9235893 into NuGet:main Feb 18, 2025
3 checks passed
@RussKie
Copy link
Contributor Author

RussKie commented Feb 18, 2025

7 months... not bad :)

@RussKie RussKie deleted the patch-1 branch February 18, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants