Added code to clear the text #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognitivegears
requested changes
Sep 22, 2023
There was a problem hiding this comment.
This looks like a great change! See below for one small comment -
core/text_view.js
Outdated
| @@ -179,6 +179,10 @@ TextView.prototype.setText = function (text, redraw) { | |||
| }; | |||
|
|
|||
| TextView.prototype.clearText = function () { | |||
| if (this.text) { | |||
| this.setText(' '.repeat(this.text.length)); | |||
There was a problem hiding this comment.
Can we use this.fillChar here instead of a literal space?
added 2 commits
September 22, 2023 14:05
…yHarwood/enigma-bbs into bugfix/TextView_clearText
AnthonyHarwood
commented
Sep 22, 2023
cognitivegears
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Looks good to me, I'll wait for @NuSkooler in case he has any concerns but thanks so much for the PR, keep 'em coming :)
NuSkooler
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the text in the error view was not being cleared after the error was corrected. For example, "Username is too short".
I can think of a few different ways this could have been fixed. I try to keep it simple. If you prefer a different approach to resolving this, please don't hesitate to let me know.
Thanks!