Fix for mail to invalid FTN address #505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To reproduce the issue, create a mail message and address it to 555 |
|
@NuSkooler can you test this out? I don't have any fidonet networks configured. |
NuSkooler
reviewed
Sep 26, 2023
| // - Supported remote flavors such as FTN, email, ... | ||
| // | ||
| // :TODO: remove hard-coded FTN check here. We need a decent way to register global supported flavors with modules. | ||
| const addressedToInfo = getAddressedToInfo(data); |
There was a problem hiding this comment.
Looks like we're just catching a undefined/null. This can probably be switched to a less heavy if (!addressedToInfo) { }.
For the error itself, please use Errors.Invalid, e.g. Errors.Invalid('Invalid address')
|
Thanks for catching this! I left a small comment for a tidy, but should be good to go after |
|
Closing this and submitting a simpler solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a handler to catch invalid FTN address, that was closing socket connection.