default rxtx binary mode configuration reflects bitmode value #934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing:
Does not set the file format to 8 bits:
That's because the file format is updated inside the
rxtx_str2fmt
function only if theformat
option is provided on therx/tx config
command. I think it makes sense to use as default SC8Q7 if the user specifies 8 bits instead of the default SC16Q11.My idea was to update the default mode when the
set bitmode
command is processed, but when looking at how the code is organized I thought this was a better idea. Let me know if you are ok with it or would prefer another approach.Thanks!