Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leash events #51

Draft
wants to merge 1 commit into
base: 1.21
Choose a base branch
from
Draft

Conversation

haykam821
Copy link
Contributor

This pull request adds events for attaching and detaching entities from leashes (using the vanilla lead item, for example). In particular, the following two events are added:

  • Attach
    • Interacting with an unleashed entity while holding a lead
    • Interacting with a leash knot while leashing an entity
    • Interacting with a fence containing a leash knot while leashing an entity
  • Detach
    • Interacting with an entity leashed by the player

Entity deserialization-related attachment and detachment is not included in these events. I am not sure whether or how causes such as a leash knot breaking and detaching entities due to not being supported by a fence or a leashed entity being too far away from its leash holder should be considered in these events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant