Show resist mod in attribute tooltips. #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an active effect is adjusting an attribute, show the resistance percentage modifying the adjustment, in addition to the raw adjustment value.
Petethegoat
added a commit
that referenced
this pull request
Jan 22, 2025
|
Thanks for your contribution. I have implemented it slightly differently here - https://github.com/NullCascade/morrowind-mods/compare/resist-mod Instead of showing the resistance percentage, which needs context to understand what you're looking at, I just show the actual modification to the stat, accounting for the resistance. Sorry it took a year to have this looked at and thanks again. |
|
Merged in #70. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an active effect is adjusting an attribute, show the resistance percentage modifying the adjustment, in addition to the raw adjustment value.
This may be desirable, because the raw value can differ significantly from the actual change (in vanilla due to a birthsign like Elfborn, or when mods like Putting the Will in Willpower are used). Seeing the adjustment percentage alongside the raw value can help the player determine why they are seeing the numbers they are seeing.