Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix default config parsing #83

Merged
merged 4 commits into from
Feb 15, 2024
Merged

fix default config parsing #83

merged 4 commits into from
Feb 15, 2024

Conversation

yushindkang
Copy link
Contributor

@yushindkang yushindkang commented Feb 15, 2024 •
edited
Loading

Description

Please include a summary of the change with relevant motivation and context

Linked Issues & PRs

  • resolves
  • relates to

GitHub Issue Linking Docs

Checklist

  • I have added one of the patch, minor, major or no-release labels
  • I have linked an issue from this repository using the Development option
  • I have performed a self-review of my own code
  • I have checked for redundant or commented out code
  • I have commented my code where I can't make it self-documenting
  • I have made corresponding changes to the documentation
  • I have added any appropriate tests

@tim-thacker-nullify
Copy link
Member

@yushindkang unit test is failing i think

@yushindkang yushindkang added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit 9109649 Feb 15, 2024
5 checks passed
@yushindkang yushindkang deleted the fix-global-threshold-error branch February 15, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-thacker-nullify tim-thacker-nullify tim-thacker-nullify approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yushindkang @tim-thacker-nullify