build.sh accepts version argument #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build.sh with no arguments builds all versions build.sh <version> builds single version build.sh latest builds latest version build.sh src builds from src/oas.md Resolve Google Analytics snippet location relative to md2html.js Update tests to reflect inclusion of snippet Pre-requisite to OAI#4341
duncanbeevers
force-pushed
the
build-src-changes
branch
from
ad15ba6 to
9449ce8
Compare
duncanbeevers
changed the title
3 tasks
ralfhandl
requested changes
Feb 9, 2025
scripts/md2html/build.sh
Outdated
Comment on lines
45
to
51
| if [ "$1" = "src" ]; then | ||
| destination="$deploydir/$version.html" | ||
| maintainers="EDITORS.md" | ||
| else | ||
| destination="$deploydir/v$version.html" | ||
| maintainers="$(dirname $specification)/$version-editors.md" | ||
| fi |
There was a problem hiding this comment.
Move this up and set deploydir to deploy-preview only for "src".
There was a problem hiding this comment.
I moved this as far up the block as I could, but as these values depend on $version, they need to be defined in-loop.
|
One more thing:
|
build.sh with no arguments builds all versions build.sh <version> builds single version build.sh latest builds latest version build.sh src builds from src/oas.md Resolve Google Analytics snippet location relative to md2html.js Update tests to reflect inclusion of snippet Pre-requisite to OAI#4341
ralfhandl
reviewed
Feb 10, 2025
ralfhandl
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.shwith no arguments builds all versionsbuild.sh <version>builds single versionbuild.sh latestbuilds latest versionbuild.sh srcbuilds from src/oas.mdPre-requisite to #4341