-
Notifications
You must be signed in to change notification settings - Fork 9.1k
v3.2: $self
field (Alternative Approach)
#4556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
handrews
wants to merge
12
commits into
OAI:v3.2-dev
Choose a base branch
from
handrews:self3
base: v3.2-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7bd8a15
Add `$self` for self-identifying documents
handrews 71ec162
Fix missing multipart boundary
handrews db9f643
Move base URI examples to appendix
handrews 2832652
Improved examples
handrews 4435fd3
Fix more example bugs
handrews 182ca17
All example URI paths start with /api/...
handrews 7be51a4
Allow relative `$self`, include examples
handrews 4068c09
Fix another base URI example bug
handrews 966c0c6
Apply suggestions from code review
handrews eace593
Better wording
handrews 8709e12
Review feedback
handrews fc66d13
Remove link to metaschema...
handrews File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we consistently use "retrieval URL"?
Currently we have a mix of "retrieval URI" and "retrieval URL", and the L-variant is more accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you actually retrieved something, it's the retrieval URL. When you supply it as a simulation of having retrieved it, it's more properly a retrieval URI, which is how RFC3986 states it.
So if we only use one, it should be retrieval URI, not retrieval URL.