Use custom server icon, MOTD and gamemode #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edewit
previously approved these changes
Apr 2, 2022
|
@vorburger seems there is a conflict |
Based on https://github.com/OASIS-learn-study/s2i-minecraft-server/blob/master/src/server.properties, I've verified each of the properties we had there, but most of them were the defaults anyway, this is better.
vorburger
force-pushed
the
icon-motd-gamemode
branch
from
4ef3f66 to
578ee8e
Compare
fixed (but perhaps wait for the build that just kicked off to successfully finish before merging) |
edewit
approved these changes
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The creative gamemode was surprisingly more painful to get working than you would think it should be! (Due to 2 different problems, one was itzg/docker-minecraft-server#1452 and the other one a confusing bug in our
GuardGameModeJoinListener.)This is part of #276, with more to come, but @edewit do merge this already if it LGTY as is, as a first step.
This includes #289 which you could merge first if you like.