This repository has been archived by the owner on Jul 3, 2020. It is now read-only.
Stops requiring a client secret when the "password" grant type is used #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagozf
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the use cases for password grants are highly trusted mobile or desktop apps. These clientes are public, which means that the client secret cannot be protected (an attacker could extract it from binaries).
Since this grant type already exchanges username and password for an access token directly, the authorization server can ignore the
client_secretparam to validate the client. This prevents attackers from obtaining the client secret and exploring it on other grant types (code grant, for example).Right now, Apis is requiring a
client_secretto be defined in order to authenticate with the grant type.This pull request fixes this issue.